-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing build script to only publish alerting zip #1605
Fixing build script to only publish alerting zip #1605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were indeed publishing the zip to maven as well.
This change will only push to S3 without publishing to maven.
https://repo1.maven.org/maven2/org/opensearch/plugin/alerting/2.15.0.0/
@peterzhuamazon this change should push and publish (the opensearch-alerting) as expected but would just avoid the |
Got it, I do realize now there are two zips. Thanks. |
It should not because the |
Signed-off-by: Megha Goyal <[email protected]>
8550007
to
5cb14dd
Compare
Yes, only the zip gets created as I shared in the build output. When copying the zip files, the above logic will make sure that only alerting zip gets copied. |
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit a2cbff6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit a2cbff6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Megha Goyal <[email protected]>
(cherry picked from commit a2cbff6) Signed-off-by: Megha Goyal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a2cbff6) Signed-off-by: Megha Goyal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Issue #, if available:
#1599
Description of changes:
PR #1604 fixes the issue of publishing the zip to maven, but it had a side-effect of also publishing the remote monitor plugin zip to the artifacts folder. This PR fixes this issue, attaching the output of the build.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.